Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drop 32 bit arm support #4682

Closed
wants to merge 5 commits into from
Closed

fix: drop 32 bit arm support #4682

wants to merge 5 commits into from

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Sep 16, 2023 •
edited
Loading

Description

The "Tendermint in production" documentation states that we should not use 32 bit arm, or 32 bit CPUs generally.

https://docs.tendermint.com/v0.34/tendermint-core/running-in-production.html#validator-signing-on-32-bit-architectures-or-arm

Commit Message / Changelog Entry

fix: drop 32 bit arm support

see the guidelines for commit messages. (view raw markdown for examples)

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

DimitrisJim
DimitrisJim approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdk does test against it, the main rationale for dropping it was 08-wasm and wasmVM which flat out doesn't support it, since that will be separate go mod though we could still keep it for ibc-go. Either way, fine with dropping it.

srdtrk
srdtrk reviewed Sep 18, 2023
View reviewed changes
Copy link
Member

@srdtrk srdtrk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly in favour of closing this PR after hearing @DimitrisJim

@charleenfei
Copy link
Contributor

thanks for this @faddat! but i guess I don't really see why keeping arm32 support in for our code/framework is necessarily a bad thing at this point, there hasn't been a huge increased overhead for our team i think. support just closing this PR!

@faddat
Copy link
Contributor Author

faddat commented Sep 18, 2023 •
edited
Loading

Soooooo

+1 to @DimitrisJim -- I knew about this issue due to years of trying to run tendermint on raspberry pi while those were 32 bit or were 64 bit but had only 32 bit oses.

I suppose that if we can get a build running with 32 bit, then we are all set. To my knowledge, we will run into arm and 32 bit issues with wasmvm in our stack now.

Feel free to close, if desired to close though.

@srdtrk
Copy link
Member

srdtrk commented Sep 18, 2023

Closing for now since the SDK does test against it. Wasm is not a requirement for ibc-go. We can reopen if SDK stops testing against this or it causes us other problems.

@srdtrk srdtrk closed this Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srdtrk srdtrk srdtrk left review comments

@DimitrisJim DimitrisJim DimitrisJim approved these changes

@damiannolan damiannolan damiannolan approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@charleenfei charleenfei Awaiting requested review from charleenfei

@chatton chatton Awaiting requested review from chatton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@faddat @charleenfei @srdtrk @damiannolan @DimitrisJim